From ad112e7b4072ceb3d6ad7513c45836a6e529f2c4 Mon Sep 17 00:00:00 2001
From: Stedoss <29103029+Stedoss@users.noreply.github.com>
Date: Mon, 10 Mar 2025 22:41:24 +0000
Subject: [PATCH] Use companion objects for static version and health

---
 .../com/nisemoe/nise/controller/HealthController.kt  | 12 +++++++-----
 .../com/nisemoe/nise/controller/VersionController.kt | 12 +++++++-----
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/nise-backend/src/main/kotlin/com/nisemoe/nise/controller/HealthController.kt b/nise-backend/src/main/kotlin/com/nisemoe/nise/controller/HealthController.kt
index 47e6f78..b4f7f11 100644
--- a/nise-backend/src/main/kotlin/com/nisemoe/nise/controller/HealthController.kt
+++ b/nise-backend/src/main/kotlin/com/nisemoe/nise/controller/HealthController.kt
@@ -8,15 +8,17 @@ data class HealthResponse(
     val healthy: Boolean,
 )
 
-val healthResponse = HealthResponse(
-    healthy = true,
-)
-
 @RestController
 class HealthController {
+    companion object {
+        val HEALTH = HealthResponse(
+            healthy = true,
+        )
+    }
+
     @GetMapping("/health")
     fun healthCheck(): ResponseEntity<HealthResponse> {
-        return ResponseEntity.ok(healthResponse)
+        return ResponseEntity.ok(HEALTH)
     }
 }
 
diff --git a/nise-backend/src/main/kotlin/com/nisemoe/nise/controller/VersionController.kt b/nise-backend/src/main/kotlin/com/nisemoe/nise/controller/VersionController.kt
index 5f4552d..902f15e 100644
--- a/nise-backend/src/main/kotlin/com/nisemoe/nise/controller/VersionController.kt
+++ b/nise-backend/src/main/kotlin/com/nisemoe/nise/controller/VersionController.kt
@@ -8,12 +8,14 @@ data class VersionResponse(
     val version: String,
 )
 
-val versionResponse = VersionResponse(
-    version = "v20250310",
-)
-
 @RestController
 class VersionController {
+    companion object {
+        val VERSION = VersionResponse(
+            version = "v20250310",
+        )
+    }
+
     @GetMapping("/version")
-    fun getVersion(): ResponseEntity<VersionResponse> = ResponseEntity.ok(versionResponse)
+    fun getVersion(): ResponseEntity<VersionResponse> = ResponseEntity.ok(VERSION)
 }
\ No newline at end of file